Conversation
silesmo
force-pushed
the
dev/timmy/csharp-macos-support
branch
3 times, most recently
from
facead9 to
0df3a74
Compare
silesmo
force-pushed
the
dev/timmy/csharp-macos-support
branch
from
0df3a74 to
7373933
Compare
yowl
left a comment
yowl
left a comment
There was a problem hiding this comment.
Just curious about fixing the commit.
| lang: csharp | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| RUNTIMELAB_COMMIT: '4cac3ab5c8e97fda69c23dfca41ace964babc05e' |
There was a problem hiding this comment.
Maybe not, was just for consistency in case the latest version caused something to break. But we can remove it if you want?
| ./build.sh libs -c Release /p:NuGetAudit=false | ||
| LLVM_CMAKE_CONFIG_RELEASE=$(brew --prefix llvm@18)/lib/cmake/llvm \ | ||
| src/coreclr/build-runtime.sh -arm64 -release -os osx -outputrid osx-arm64 -component llvmjit | ||
| cp artifacts/bin/coreclr/osx.arm64.Release/libclrjit_universal_llvm32_arm64.dylib artifacts/bin/coreclr/osx.arm64.Release/ilc-published/ |
There was a problem hiding this comment.
Interesting, something must be missing in the runtimelab build to make this necessary. Not saying anything needs changing, just if we want to push this to runtimelab, we will have to make the build copy these files.
| <PackageReference Include="Microsoft.DotNet.ILCompiler.LLVM" Version="10.0.0-*" /> | ||
| <PackageReference Include="runtime.{os}-x64.Microsoft.DotNet.ILCompiler.LLVM" Version="10.0.0-*" /> | ||
| <PackageReference Include="Microsoft.DotNet.ILCompiler.LLVM" Version="{ilc_version}" /> | ||
| <PackageReference Include="runtime.{os}-{arch}.Microsoft.DotNet.ILCompiler.LLVM" Version="{ilc_version}" /> |
There was a problem hiding this comment.
This might be a problem for arm64 on windows as we don't have that either.
There was a problem hiding this comment.
Yes this is true. I can add a not supported error for now?
|
What is the effect on the build time? An alternative is to push whatever might be needed to runtimelab and will build the nuget there. |
It took 36m 36s But the build of runtimelab took 27m and 43s of that time and it gets cached so it wont take so long for following runs (This is actually a reason to pin it to a specific hash so we don't have to rebuild every time @yowl) |
2 participants
Build and test it ourselves since it's not a published package based on: dotnet/runtimelab#2119